use the new action to create an issue from the output of reportlog#7212
Merged
keewis merged 7 commits intopydata:mainfrom Oct 26, 2022
Merged
use the new action to create an issue from the output of reportlog#7212keewis merged 7 commits intopydata:mainfrom
keewis merged 7 commits intopydata:mainfrom
Conversation
github-actions
bot
added
the
Automation
andersy005
approved these changes
Oct 25, 2022
Member
andersy005
left a comment
andersy005
left a comment
There was a problem hiding this comment.
Looks solid to me 👍🏽... Thank you, @keewis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if we actually need the dedicated "report" job, or whether adding an additional step to the main ci job would suffice?
I can see two reasons for a separate job:
I think if we can change the action to abort if it is run on a python version it does not support the first concern would not matter anymore, and for 2 we might just keep the "upload artifact" action (but is it even possible to manually access artifacts? If not we might not even need the upload).
Since I don't think either is a major concern, I went ahead and joined the jobs.